cw1-subkeys: Point helper to smart contract version v0.2.1 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orkunkl
commented
Sep 10, 2020
| @@ -346,10 +346,10 @@ const CW1 = (client: SigningCosmWasmClient): CW1Contract => { | |||
|
|
|||
| const upload = async (): Promise<number> => { | |||
| const meta = { | |||
| source: "https://github.com/CosmWasm/cosmwasm-plus/tree/v0.1.1/contracts/cw1-subkeys", | |||
| source: "https://github.com/CosmWasm/cosmwasm-plus/tree/v0.2.1/contracts/cw1-subkeys", | |||
| builder: "cosmwasm/rust-optimizer:0.10.1" | |||
There was a problem hiding this comment.
Suggested change
| builder: "cosmwasm/rust-optimizer:0.10.1" | |
| builder: "cosmwasm/workspace-optimizer:0.10.3" |
Should I apply this change?
There was a problem hiding this comment.
I suppose we need to apply the meta change in every contract
There was a problem hiding this comment.
Yes, good to update.
But we are building with 0.10.2: https://github.com/CosmWasm/cosmwasm-plus/blob/master/.circleci/config.yml#L491
(Is 0.10.3 out?)
ethanfrey
approved these changes
Sep 10, 2020
| @@ -346,10 +346,10 @@ const CW1 = (client: SigningCosmWasmClient): CW1Contract => { | |||
|
|
|||
| const upload = async (): Promise<number> => { | |||
| const meta = { | |||
| source: "https://github.com/CosmWasm/cosmwasm-plus/tree/v0.1.1/contracts/cw1-subkeys", | |||
| source: "https://github.com/CosmWasm/cosmwasm-plus/tree/v0.2.1/contracts/cw1-subkeys", | |||
| builder: "cosmwasm/rust-optimizer:0.10.1" | |||
There was a problem hiding this comment.
Yes, good to update.
But we are building with 0.10.2: https://github.com/CosmWasm/cosmwasm-plus/blob/master/.circleci/config.yml#L491
(Is 0.10.3 out?)
|
Just merged #83 Now I see why you changed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, merge #83 if no objections or blockers
Then release v0.2.1
Then merge this.